Raise RuntimeWarning if jax > 0.4.28 is installed
#6864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6864 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 480 480
Lines 45409 45421 +12
=======================================
+ Hits 45224 45236 +12
Misses 185 185 ☔ View full report in Codecov by Sentry. |
albi3ro
reviewed
Jan 21, 2025
andrijapau
reviewed
Jan 21, 2025
andrijapau
reviewed
Jan 31, 2025
albi3ro
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jax is not compatible with pennylane for versions > 0.4.28 (confirmed by the test logs of this PR). This PR raises a
RuntimeWarningif version > 0.4.28 is installed:QNode.__init__if the specified interface resolves toJAXorJAX_JITexecuteif the original interface was"auto"orNoneand the resolved interface isJAXorJAX_JIT. I don't raise a warning if the original interface was jax/jax-jit because if that is the case,QNode.__init__should've already raised a warning._validate_jax_versionprivate kwarg toqml.math.get_canonical_interface_name, which is called byQNode.__init__, andqml.workflow.resolution._resolve_interface(used byqml.execute), so that both those entry points can raise warnings if appropriate.Possible drawbacks:
None. The only annoying is that our CI uses supported versions of jax, so we can't get coverage for the runtime warning. I've added a
# pragma: no coverto work around this, but I'm not particularly happy about it.[sc-82570]